Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igx-carousel accessibility improvements #8202

Closed
kdinev opened this issue Sep 25, 2020 · 2 comments · Fixed by #8864
Closed

igx-carousel accessibility improvements #8202

kdinev opened this issue Sep 25, 2020 · 2 comments · Fixed by #8864
Assignees
@zdrawku @ddincheva
Labels
🎠 carousel program: igniteui project management 🧰 feature-request ♿ a11y When the issue or PR is related to accessibility ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Sep 25, 2020

Is your feature request related to a problem? Please describe.

The current aria roles applied on the igx-carousel widget fail in an accessibility scan. The carousel is marked as role="list", but slides are not marked as list items.

Describe the solution you'd like

The carousel should be handled as a tab widget, where the buttons to choose a slide are tabs and the slides are tabpanels.

Additional context

Put a carousel component in a document and run the lighthouse scan to check the a11y failures.
@kdinev kdinev added 🎠 carousel ♿ a11y When the issue or PR is related to accessibility 🧰 feature-request labels Sep 25, 2020
@zdrawku zdrawku self-assigned this Sep 28, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Nov 28, 2020
@nrobakova nrobakova removed the status: inactive Used to stale issues and pull requests label Nov 30, 2020
@zdrawku zdrawku assigned ddincheva and unassigned nrobakova Jan 13, 2021
@radomirchev radomirchev added the program: igniteui project management label Jan 19, 2021
@zdrawku zdrawku added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 21, 2021
ddincheva added a commit that referenced this issue Jan 28, 2021
@ddincheva
feat(IgxCarousel): enhance accessibility #8202
8948f1b
ddincheva added a commit that referenced this issue Jan 28, 2021
@ddincheva
feat(IgxCarousel): enhance aria attributes in the slide component #8202
8914fc5
ddincheva added a commit that referenced this issue Jan 28, 2021
@ddincheva
fix(IgxSlideComponnet): update aria attributes correctly #8202
1a234c2
ddincheva added a commit that referenced this issue Jan 28, 2021
@ddincheva
fix(IgxCarousel): add correct aria attributes #8202
4922db6
ddincheva added a commit that referenced this issue Jan 28, 2021
@ddincheva
test(Carousel): add basic aria tests #8202
7044b7b
@ddincheva ddincheva mentioned this issue Jan 28, 2021
Merged
14 tasks
@ddincheva ddincheva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 28, 2021
ddincheva added a commit that referenced this issue Jan 29, 2021
@ddincheva
fix(IgxCarousel): auto rotation is turned on-the live region is disab…
9b9a8e9 
…led #8202
@zdrawku
Copy link
Contributor

zdrawku commented Feb 1, 2021

Specification update with latest a11y changes

@zdrawku zdrawku mentioned this issue Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdrawku zdrawku

@ddincheva ddincheva

Labels
🎠 carousel program: igniteui project management 🧰 feature-request ♿ a11y When the issue or PR is related to accessibility ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

igx-carousel accessibility improvements IgniteUI/igniteui-angular
5 participants
@kdinev @zdrawku @nrobakova @ddincheva @radomirchev