Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(exporter): mark extra pivot methods private #14434

Merged
merged 3 commits into from
Jun 25, 2024
Merged

refactor(exporter): mark extra pivot methods private #14434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbb2fb2
refactor(exporter): mark extra pivot methods private
damyanpetev Jun 25, 2024
29a1a64
docs(toolbar): minor deprecation reformat
damyanpetev Jun 25, 2024
5f40da0
docs(grid): event args interface minor typo
damyanpetev Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/grids/common/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export interface IGridCellEventArgs extends IBaseEventArgs {
/** Represents the grid cell that triggered the event. */
cell: CellType;
/**
* Represents the original event that ocurred
* Represents the original event that occurred
* Examples of such events include: selecting, clicking, double clicking, etc.
*/
event: Event;
Expand All @@ -35,7 +35,7 @@ export interface IGridRowEventArgs extends IBaseEventArgs {
/** Represents the grid row that triggered the event. */
row: RowType;
/**
* Represents the original event that ocurred
* Represents the original event that occurred
* Examples of such events include: selecting, clicking, double clicking, etc.
*/
event: Event;
Expand Down
3 changes: 1 addition & 2 deletions projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ export class IgxGridToolbarComponent implements OnDestroy {
/**
* Gets/sets the grid component for the toolbar component.
*
* @deprecated since version 17.1.0.
* No longer required to be set for the Hierarchical Grid child grid template
* @deprecated since version 17.1.0. No longer required to be set for the Hierarchical Grid child grid template
*
* @remarks
* Usually you should not set this property in the context of the default grid/tree grid.
Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/services/exporter-common/base-export-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1275,7 +1275,7 @@ export abstract class IgxBaseExporter {
return result;
}

public addPivotRowHeaders(grid: any) {
private addPivotRowHeaders(grid: any) {
if (grid?.pivotUI?.showRowHeaders) {
const headersList = this._ownersMap.get(DEFAULT_OWNER);
const enabledRows = grid.pivotConfiguration.rows.filter(r => r.enabled).map((r, index) => ({ name: r.displayName || r.memberName, level: index }));
Expand All @@ -1298,7 +1298,7 @@ export abstract class IgxBaseExporter {
}
}

public addPivotGridColumns(grid: any) {
private addPivotGridColumns(grid: any) {
if (grid.nativeElement.tagName.toLowerCase() !== 'igx-pivot-grid') {
return;
}
Expand Down
Loading