Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(igx-grid): Preserve selection on non-primary click #4879

Merged
merged 19 commits into from
Jun 17, 2019
Merged

fix(igx-grid): Preserve selection on non-primary click #4879

merged 19 commits into from
Jun 17, 2019

Conversation

rkaraivanov
Copy link
Member

@rkaraivanov rkaraivanov commented May 23, 2019 •
edited
Loading

Closes #4878

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@rkaraivanov rkaraivanov requested a review from kdinev May 23, 2019 06:15
@HristoP96 HristoP96 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 23, 2019
HristoP96
HristoP96 suggested changes May 23, 2019
View reviewed changes
Copy link

@HristoP96 HristoP96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onRangeSelection event does not get triggered when we make multi cell selection with the mouse

@rkaraivanov rkaraivanov added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels May 27, 2019
@HristoP96 HristoP96 mentioned this pull request May 31, 2019
Merged
@nrobakova nrobakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 10, 2019
@nrobakova nrobakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 10, 2019
@zdrawku zdrawku merged commit fed0a54 into 7.3.x Jun 17, 2019
@zdrawku zdrawku deleted the rkaraivanov/multi-selection-73 branch June 17, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HristoP96 HristoP96 HristoP96 approved these changes

@kdinev kdinev Awaiting requested review from kdinev

Assignees

@nrobakova nrobakova

@HristoP96 HristoP96

Labels
grid: multi-cell-selection version: 7.3.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rkaraivanov @HristoP96 @zdrawku @nrobakova @kdinev