-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
igx-carousel accessibility improvements #8864
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8948f1b
feat(IgxCarousel): enhance accessibility #8202
ddincheva 8914fc5
feat(IgxCarousel): enhance aria attributes in the slide component #8202
ddincheva afc5cd7
chore(*): add up more resource string to carousel component
ddincheva f66b471
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
ddincheva 98ef669
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
ddincheva 1a234c2
fix(IgxSlideComponnet): update aria attributes correctly #8202
ddincheva 4922db6
fix(IgxCarousel): add correct aria attributes #8202
ddincheva 7044b7b
test(Carousel): add basic aria tests #8202
ddincheva 5bb6492
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
ddincheva 768d6e3
chore(*): fix linting errors
ddincheva f510895
chore(*): fix linting error
ddincheva e50eb02
Merge branch 'master' into ddincheva/carouselAria
kdinev b29bca0
chore(IgxCarousel): address lint warnings
ddincheva 9b9a8e9
fix(IgxCarousel): auto rotation is turned on-the live region is disab…
ddincheva f5d3907
chore(*): addressing requested changes
ddincheva 93391e8
chore(*): addressing requested changes
ddincheva c3bc83d
Merge branch 'master' into ddincheva/carouselAria
zdrawku a469ba2
chore(Igxcarousel): labelledby is set only if the label is visible
ddincheva 65dbd99
chore(*): removing forgotten semicolon
ddincheva 5e5cd3c
chore(Slide): remove aria-selected attribute
ddincheva e5bdd72
Merge branch 'ddincheva/carouselAria' of https://github.com/IgniteUI/…
ddincheva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
projects/igniteui-angular/src/lib/carousel/carousel.directives.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's set this aria attr only when the label is visible - which is happening when the total slides are more than the
maximumIndicatorsCount
(5)