-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-style globbing #51
base: next
Are you sure you want to change the base?
Conversation
This adds gits wildmatch.c and adapts it to build outside the git-tree. wildmatch allows the ** wildcard, which also matches / in paths.
Thanks for contributing. In freeing is_glob_special from the git tree, please explain your replacing:
with:
What was your source for your modified is_glob_special? They don't seem equivalent. What behavioral change is introduced? Also, globs in udevil have a prominent role in security. Has git's wildmatch.c performed in a security-related role, is it well-debugged, etc? Why should I trust this code in an suid program which handles system security via globbing? Thanks. I have pulled your changes in my git-glob branch for consideration and testing. However, I changed is_glob_special back to the original - is there a reason why this won't work as-is? |
Review Notes:
|
I see IG has already taken this apart, but since I've been asked for input, what is the use case for matching '/'? Do you have some really complicated hierarchies to manage? |
Please see this comment on next branch minimal changes for this. |
This adds git-style globbing, which also matches / in paths names as requested in #37.
My autogen is a newer version than the one used on the master branch, so I added the update in a separate commit (without the globbing change) in order to supply the changes to the build-files introduced by the globbing addition properly.