Updated osx_image to xcode8.2, close #334 #350

Iron-Ham · 2016-12-21T23:31:13Z

Changes in this pull request

Updated osx_image in Travis to xcode8.2, as in: Update travis-ci to Xcode8.2 #334
Doesn't require tests, as it'll either pass with no changes to the codebase or break CI. 🤷🏽‍♂️

Pull request checklist

All tests pass. Demo project builds and runs.
I added tests, an experiment, or detailed why my change isn't tested.
I have reviewed the contributing guide

facebook-github-bot · 2016-12-21T23:32:56Z

@heshamsalman updated the pull request - view changes

facebook-github-bot · 2016-12-21T23:33:20Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T02:18:26Z

Coverage remained the same at 97.955% when pulling 0c0308d on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

facebook-github-bot · 2016-12-22T02:27:00Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T02:50:11Z

Coverage remained the same at 97.955% when pulling b070f7f on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

jessesquires

Thanks @heshamsalman ! 🎉

Looks like we need a few more tweaks. 😄

jessesquires · 2016-12-22T03:54:02Z

.travis.yml

@@ -36,6 +36,7 @@ env:

   - DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO"
   - DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO"  RUN_UI_TESTS="YES" POD_LINT="NO"
+   - DESTINATION="OS=10.2,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO"  RUN_UI_TESTS="YES" POD_LINT="NO"


RUN_UI_TESTS should be NO

@jessesquires what's the rational for running UI/Unit tests on some targets but not others?

@heshamsalman - oops, sorry. just saw this.

they are flaky, in general but specifically on travis too

jessesquires · 2016-12-22T03:54:14Z

.travis.yml

@@ -14,7 +14,7 @@ env:
   - TVOS_SCHEME="IGListKit-tvOS"
   - MACOS_SCHEME="IGListKit-macOS"

-   - IOS_SDK=iphonesimulator10.1
+   - IOS_SDK=iphonesimulator


should be iphonesimulator10.2

jessesquires · 2016-12-22T03:55:49Z

.travis.yml

@@ -14,7 +14,7 @@ env:
   - TVOS_SCHEME="IGListKit-tvOS"
   - MACOS_SCHEME="IGListKit-macOS"

-   - IOS_SDK=iphonesimulator10.1
+   - IOS_SDK=iphonesimulator
   - TVOS_SDK=appletvsimulator10.0


should be appletvsimulator10.1

facebook-github-bot · 2016-12-22T04:16:40Z

@heshamsalman updated the pull request - view changes

jessesquires · 2016-12-22T04:29:51Z

.travis.yml

@@ -36,6 +36,7 @@ env:

   - DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO"
   - DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO"  RUN_UI_TESTS="YES" POD_LINT="NO"
+   - DESTINATION="OS=10.2,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO"  RUN_UI_TESTS="NO" POD_LINT="NO"


ok, for some reason it looks like travis thinks 10.2, iPhone 6s doesn't exist 😅 (it does)

let's try using name=iPhone 7 for 10.2

It's unable to find the due to a duplicate simulator for the 10.2 image. I'll use their suggested workaround until Travis fixes it on their end.

travis-ci/travis-ci#7031

coveralls · 2016-12-22T04:31:05Z

Coverage remained the same at 97.955% when pulling e677ae5 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

facebook-github-bot · 2016-12-22T08:54:04Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T09:14:14Z

Coverage remained the same at 97.955% when pulling 4f17572 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

facebook-github-bot · 2016-12-22T09:44:55Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T10:05:10Z

Coverage remained the same at 97.955% when pulling 2671314 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

facebook-github-bot · 2016-12-22T10:55:17Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T11:21:29Z

Coverage remained the same at 97.955% when pulling a6d5d8e on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

facebook-github-bot · 2016-12-22T11:28:21Z

@heshamsalman updated the pull request - view changes

facebook-github-bot · 2016-12-22T11:51:22Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T11:52:08Z

Coverage remained the same at 97.955% when pulling a1a5fbe on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

facebook-github-bot · 2016-12-22T12:04:24Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T12:09:18Z

Coverage remained the same at 97.955% when pulling 0622c86 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

facebook-github-bot · 2016-12-22T12:26:03Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-22T12:44:28Z

Coverage remained the same at 97.955% when pulling d3d5467 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

jessesquires · 2016-12-22T17:17:57Z

thanks so much @heshamsalman !

it looks like the ipad simulators are not duplicated.

how about we switch to iPad Air 2 for 10.2? then we won't need this workaround

facebook-github-bot · 2016-12-22T19:21:04Z

@heshamsalman updated the pull request - view changes

coveralls · 2016-12-23T00:05:07Z

Coverage increased (+0.01%) to 97.967% when pulling 3b1c6d9 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

coveralls · 2016-12-23T00:05:07Z

Coverage increased (+0.01%) to 97.967% when pulling 3b1c6d9 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

coveralls · 2016-12-23T00:05:07Z

Coverage increased (+0.01%) to 97.967% when pulling 3b1c6d9 on heshamsalman:chore/update_travis_version into 2957ee5 on Instagram:master.

jessesquires

Looks like travis is ✅

Thanks so much for the time and patience @heshamsalman ! 🙌

Iron-Ham · 2016-12-23T00:40:18Z

🤠 Just glad to contribute!

facebook-github-bot · 2016-12-23T03:08:23Z

@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

heshamsalman added 2 commits December 21, 2016 18:28

Updated osx_image to xcode8.2

1431dc3

run tests on 10.2

814e07f

Update simulator vesion

0c0308d

facebook-github-bot added the CLA Signed label Dec 21, 2016

remove explicit iphonesimulator versioning

b070f7f

jessesquires suggested changes Dec 22, 2016

View reviewed changes

Made changes as requested by Jesse

e677ae5

jessesquires reviewed Dec 22, 2016

View reviewed changes

Updated 10.2 definition to iPhone 7

4f17572

Workaround as suggested by Travis issue

2671314

Add explanation comment

a1a5fbe

Iron-Ham force-pushed the chore/update_travis_version branch from a6d5d8e to a1a5fbe Compare December 22, 2016 11:27

Iron-Ham force-pushed the chore/update_travis_version branch from 0622c86 to a1a5fbe Compare December 22, 2016 12:03

swap simulator id

d3d5467

Switched 10.2 target to iPad Air 2

3b1c6d9

jessesquires approved these changes Dec 23, 2016

View reviewed changes

jessesquires changed the title ~~Updated osx_image to xcode8.2~~ Updated osx_image to xcode8.2, close #334 Dec 23, 2016

facebook-github-bot closed this in 4bb3bbd Dec 23, 2016

jessesquires mentioned this pull request Jan 3, 2017

Use Xcode8.2 in Travis jessesquires/JSQCoreDataKit#111

Merged

4 tasks

Updated osx_image to xcode8.2, close #334 #350

Updated osx_image to xcode8.2, close #334 #350

Conversation

Iron-Ham commented Dec 21, 2016 • edited Loading

Changes in this pull request

Pull request checklist

facebook-github-bot commented Dec 21, 2016

facebook-github-bot commented Dec 21, 2016

coveralls commented Dec 22, 2016 • edited Loading

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 22, 2016 • edited Loading

jessesquires left a comment

Choose a reason for hiding this comment

jessesquires Dec 22, 2016

Choose a reason for hiding this comment

Iron-Ham Dec 22, 2016

Choose a reason for hiding this comment

jessesquires Jan 3, 2017

Choose a reason for hiding this comment

jessesquires Dec 22, 2016

Choose a reason for hiding this comment

jessesquires Dec 22, 2016

Choose a reason for hiding this comment

facebook-github-bot commented Dec 22, 2016

jessesquires Dec 22, 2016

Choose a reason for hiding this comment

Iron-Ham Dec 22, 2016

Choose a reason for hiding this comment

coveralls commented Dec 22, 2016 • edited Loading

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 22, 2016 • edited Loading

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 22, 2016 • edited Loading

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 22, 2016 • edited Loading

facebook-github-bot commented Dec 22, 2016

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 22, 2016 • edited Loading

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 22, 2016 • edited Loading

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 22, 2016 • edited Loading

jessesquires commented Dec 22, 2016

facebook-github-bot commented Dec 22, 2016

coveralls commented Dec 23, 2016 • edited Loading

coveralls commented Dec 23, 2016

coveralls commented Dec 23, 2016

jessesquires left a comment

Choose a reason for hiding this comment

Iron-Ham commented Dec 23, 2016 • edited Loading

facebook-github-bot commented Dec 23, 2016

Iron-Ham commented Dec 21, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 22, 2016 •

edited

Loading

coveralls commented Dec 23, 2016 •

edited

Loading

Iron-Ham commented Dec 23, 2016 •

edited

Loading