Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full width item crashes grid layout #361

Closed
wants to merge 5 commits into from
Closed

Full width item crashes grid layout #361

wants to merge 5 commits into from

Conversation

zhubofei
Copy link

Fixed #352

@facebook-github-bot
Copy link
Contributor

@zhubofei updated the pull request - view changes

@zhubofei zhubofei changed the title Full width item crash grid layout Full width item crashes grid layout Dec 23, 2016
rnystrom
rnystrom suggested changes Dec 23, 2016
View reviewed changes
Copy link
Contributor

@rnystrom rnystrom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md 😎

@coveralls
Copy link

coveralls commented Dec 23, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.967% when pulling 4c313d4 on zhubofei:full-width-item into 4bb3bbd on Instagram:master.

@facebook-github-bot
Copy link
Contributor

@zhubofei updated the pull request - view changes

@coveralls
Copy link

coveralls commented Dec 23, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.97% when pulling a0a4f08 on zhubofei:full-width-item into 4bb3bbd on Instagram:master.

@coveralls
Copy link

coveralls commented Dec 23, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.97% when pulling b71dc6a on zhubofei:full-width-item into 4bb3bbd on Instagram:master.

Sherlouk
Sherlouk reviewed Dec 23, 2016
View reviewed changes
CHANGELOG.md
@@ -23,6 +23,8 @@ This release closes the [2.1.0 milestone](https://github.com/Instagram/IGListKit

- Fix out-of-bounds bug when child section controllers in a stack remove cells. [Ryan Nystrom](https://github.com/rnystrom) [(#358)](https://github.com/Instagram/IGListKit/pull/358)

- Fix a grid layout bug when item has full-width and iter-item spacing is not zero. [Bofei Zhu](https://github.com/zhubofei) [(#358)](https://github.com/Instagram/IGListKit/pull/361)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number in brackets is 358, link is 361 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@MarvinNazari MarvinNazari mentioned this pull request Dec 23, 2016
Closed
@facebook-github-bot
Copy link
Contributor

@zhubofei updated the pull request - view changes

@coveralls
Copy link

coveralls commented Dec 23, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.97% when pulling 09f9634 on zhubofei:full-width-item into 4bb3bbd on Instagram:master.

@jessesquires jessesquires added this to the 2.1.0 milestone Dec 23, 2016
@facebook-github-bot
Copy link
Contributor

@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zhubofei zhubofei deleted the full-width-item branch December 23, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sherlouk Sherlouk Sherlouk left review comments

@rnystrom rnystrom rnystrom approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zhubofei @facebook-github-bot @coveralls @rnystrom @Sherlouk @jessesquires @bofeizhu