Init without working range size #686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ocrickard, @rnystrom thought you might be interested in looking at this as well. |
rnystrom
suggested changes
Apr 21, 2017
Source/IGListAdapter.h
Outdated
| @@ -103,6 +103,17 @@ IGLK_SUBCLASSING_RESTRICTED | |||
| workingRangeSize:(NSInteger)workingRangeSize NS_DESIGNATED_INITIALIZER; | |||
|
|
|||
| /** | |||
| Initializes a new `IGListAdapter` object. | |||
There was a problem hiding this comment.
Let's add that this uses workingRangeSize 0
There was a problem hiding this comment.
Also changed the opt-out to prefer the new init over providing 0 as a value.
|
@BasThomas updated the pull request - view changes |
rnystrom
reviewed
Apr 21, 2017
Source/IGListAdapter.h
Outdated
| @@ -96,13 +96,26 @@ IGLK_SUBCLASSING_RESTRICTED | |||
| the previous and succeeding 2 objects will be notified that they are within the working range. As you scroll the list | |||
| the range is updated as objects enter and exit the working range. | |||
|
|
|||
| To opt out of using the working range, you can provide a value of `0`. | |||
| To opt out of using the working range, use `initWithUpdater:viewController` instead. | |||
There was a problem hiding this comment.
Suuuuuper nit: can this be
To opt out of using the working range, use
initWithUpdater:viewController:or provide a working range of0.
|
@BasThomas updated the pull request - view changes |
|
@BasThomas updated the pull request - view changes |
|
@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #414
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.What should we do with testing? I changed all the occurrences of the old initializer with the new one, so I think this is good to go?