Integration test template #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To run them: colcon build . install/setup.bash export ROSBAG_DIR_PATH=<records dir> colcon test --packages-select realsense2_camera --event-handlers console_direct+ colcon test-result --all --test-result-base build/realsense2_camera/test_results/ --verbose To run using pytest: pytest-3 -s realsense2_camera/test/pytest_integration_test_template.py
Check the records
…Ros/realsense-ros into integration_test_template
…Ros/realsense-ros into integration_test_template
No need of downloading rosbag files, tests download the files
| @@ -3,12 +3,14 @@ matrix: | |||
| include: | |||
| - dist: bionic | |||
| - dist: focal | |||
| - dist: jammy | |||
There was a problem hiding this comment.
is this file in use anywhere ?
There was a problem hiding this comment.
@SamerKhshiboun, I am not aware of any usage of it in the repo. May be, we can check if it's used in the dailies/weeklies? If not, we can remove this.
|
Hi @PrasRsRos, Please review/answer two comments/questions on this PR. @Nir-Az, you can merge after Prasanth answers the questions and GHA success. I think you can squash commits before merging right ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the test infra