Support Iron distro #2787
Merged
Support Iron distro #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamerKhshiboun
force-pushed
the
add-iron
branch
5 times, most recently
from
dfa9899
to
79956fe
Compare
SamerKhshiboun
commented
Jun 21, 2023
.github/workflows/pre-release.yml
Outdated
| @@ -31,12 +31,10 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ros_distro: [humble, foxy] | |||
| ros_distro: [humble] | |||
There was a problem hiding this comment.
will add iron here only when it builds and be ready on the ROS2 public package index
meanwhile, if we add it here, it will fail, since it will not find librealsense2 package for iron.
There was a problem hiding this comment.
I say let's add it and ignore Iron failure, it should be fixed once it's merged , right?
update readme
Nir-Az
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by RSDEV-353