Disabling hdr while updating exposure & gain values

[Arun-Prasad-V]

Tracked on LRS-962

Overview:

• On FW versions 5.13.0.50 and below, the FW allowed to set the preset values (like exposure, gain, etc) when HDR is enabled.
• But in later FW versions 5.14.x.x and above, updating preset values are restricted when HDR is enabled.
• This FW change affected the ROS wrapper's flow for setting the exposure and gain of sequence IDs 1 & 2 (during launch time) through below params:
  • depth_module.exposure.1
  • depth_module.gain.1
  • depth_module.exposure.2
  • depth_module.gain.2

This PR makes sure that the HDR is disabled while setting those params during launch time.

During runtime, if the HDR is enabled, the presets cannot be updated. To update them, should disable HDR first and then try.

[Nir-Az]

@Arun-Prasad-V I think we are OK with this fix,

about this
If the user wants to update any presets dynamically, its users responsibility to disable the HDR first and then update the presets.
Is it possible to add a ROS log warning if the user try to change it when HDR is enabled?
If it breaks the generic code we can try to count on LibRS warning.
We might want to rephrase it and say it is not supported.
thoughts?

[Nir-Az]

So this PR is ready to be merged?
No more “stall” on librs set option exceptions?
I am not sure what fixed it.

[Arun-Prasad-V]

So this PR is ready to be merged? No more “stall” on librs set option exceptions? I am not sure what fixed it.

The stall was happening during INIT, because HDR was not disabled while updating the exp & gain of seq_ids 1&2.
The logic to disable first -> update exp & gain -> enable back fixed the stall.