add Plutus V2 scripts to witnesses in CDDL #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashisherc
reviewed
May 18, 2022
| , ? 4: [* plutus_data ] | ||
| , ? 5: [* redeemer ] | ||
| , ? 6: [* plutus_v2_script ] ; New | ||
| } | ||
|
|
||
| plutus_script = bytes |
There was a problem hiding this comment.
probably this requires a change as well (some automated tools rely on it).
Also, I remember there was a discussion regarding using tagging for plutus script versions, that it could be easier to upgrade in future? was that idea dropped?
There was a problem hiding this comment.
yep, good catch! Looks like the test caught it too :)
JaredCorduan
force-pushed
the
jc/add_plutus_v2_wits_to_cddl
branch
from
53454e1
to
861604a
Compare
JaredCorduan
force-pushed
the
jc/add_plutus_v2_wits_to_cddl
branch
from
861604a
to
344379c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Plutus V2 script witnesses to the Babbage era CDDL file.
closes #2798