Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vasil hardfork to cardano-api and cardano-cli #3765

Merged
merged 18 commits into from
Apr 6, 2022

Conversation

Jimbo4350
Copy link
Contributor

This PR only introduces the era. It does not begin to integrate the new functionality exposed by cardano-ledger.

@Jimbo4350 Jimbo4350 mentioned this pull request Apr 4, 2022
38 tasks
@Jimbo4350 Jimbo4350 changed the title Add Vasil era to cardano-api Add Vasil era to cardano-api and cardano-cli Apr 4, 2022
@Jimbo4350 Jimbo4350 force-pushed the jordan/add-babbage-era-to-cardano-api branch from 1f07aaa to 101344d Compare April 4, 2022 16:50
@Jimbo4350 Jimbo4350 force-pushed the jordan/add-babbage-era-to-cardano-api branch from 101344d to 8c3041f Compare April 5, 2022 13:01
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jimbo4350 Jimbo4350 force-pushed the jordan/add-babbage-era-to-cardano-api branch from 4cfc7f2 to fdd304a Compare April 5, 2022 19:41
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 5, 2022
3765: Add Vasil era to cardano-api and cardano-cli r=Jimbo4350 a=Jimbo4350

This PR only introduces the era. It does not begin to integrate the new functionality exposed by `cardano-ledger`.

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 5, 2022

Build failed:

@JaredCorduan
Copy link
Contributor

one note about names: it is the Vasil hardfork, but the Babbage era 😬

@Jimbo4350 Jimbo4350 changed the title Add Vasil era to cardano-api and cardano-cli Add Vasil hardfork to cardano-api and cardano-cli Apr 5, 2022
@MarcFontaine
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 6, 2022

Merge conflict.

@Jimbo4350 Jimbo4350 force-pushed the jordan/add-babbage-era-to-cardano-api branch from 6f2de56 to 3f19137 Compare April 6, 2022 12:51
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 6, 2022
3765: Add Vasil hardfork to cardano-api and cardano-cli r=Jimbo4350 a=Jimbo4350

This PR only introduces the era. It does not begin to integrate the new functionality exposed by `cardano-ledger`.

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 6, 2022

Timed out.

@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 6, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8b6f251 into master Apr 6, 2022
@iohk-bors iohk-bors bot deleted the jordan/add-babbage-era-to-cardano-api branch April 6, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants