Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cardano-api txout with reference scripts #3779

Merged
merged 8 commits into from
Apr 11, 2022
Merged

Update cardano-api txout with reference scripts #3779

merged 8 commits into from
Apr 11, 2022

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Apr 8, 2022 •
edited
Loading

Update cardano-api's txout data type with reference scripts

@Jimbo4350 Jimbo4350 force-pushed the jordan/update-api-txout-reference-scripts branch 2 times, most recently from 78c467b to bb00280 Compare April 8, 2022 18:33
@Jimbo4350 Jimbo4350 marked this pull request as ready for review April 8, 2022 20:05
MarcFontaine
MarcFontaine approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding the tx-generator

Jimbo4350 and others added 8 commits April 11, 2022 09:01
@Jimbo4350
Implement the ReferenceScript era data type in cardano-api
f4c9a38 
Update the TxOut data type with the ability
to specify a ReferenceScript in the Babbage era.
@Jimbo4350
Propagate reference scripts to Cardano.Api.Fees
32fdf98
@Jimbo4350
Propagate reference script to Cardano.Api.TxBody. This commit is a bit
6f2f2e2 
gnarly because of the modifications needed to the TxOut JSON instances
as a result of inline datums and reference scripts being possible in
Babbage.
@Jimbo4350
Expose the ReferenceScript data type an relevant functions via Cardan…
262879a 
…o.Api.Shelley
@Jimbo4350
Implement two versions of genTxOut depending on the context (TxOut in a
73ae5fe 
Tx or in the UTxO). Add two JSON roundtrip tests for TxOuts in each of
the aforementioned contexts.
@Jimbo4350
plutus-example BabbageEra hedgehog generator updates
5caf02b
@Jimbo4350
Initial propagation of reference scripts to cardano-cli. No
ddbc50b 
functionality is implemented, only placeholders.
@MarcFontaine @Jimbo4350
Propagate changes to tx-generator
34b1e4d
@Jimbo4350 Jimbo4350 force-pushed the jordan/update-api-txout-reference-scripts branch from 2fd86b2 to 34b1e4d Compare April 11, 2022 14:04
@newhoggy newhoggy self-requested a review April 11, 2022 14:28
@Jimbo4350
Copy link
Contributor Author

bors r+

@Jimbo4350 Jimbo4350 mentioned this pull request Apr 11, 2022
Closed
38 tasks
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 11, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9d6cbe4 into master Apr 11, 2022
@iohk-bors iohk-bors bot deleted the jordan/update-api-txout-reference-scripts branch April 11, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@MarcFontaine MarcFontaine MarcFontaine approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@nc6 nc6 Awaiting requested review from nc6

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@deepfire deepfire Awaiting requested review from deepfire

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jimbo4350 @newhoggy @MarcFontaine