Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference transaction inputs to cardano-api #3804

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350 Jimbo4350 mentioned this pull request Apr 19, 2022
38 tasks
@Jimbo4350 Jimbo4350 force-pushed the jordan/cardano-api-reference-inputs branch from 5fde80c to c2307ab Compare April 20, 2022 14:47
@Jimbo4350 Jimbo4350 marked this pull request as ready for review April 20, 2022 14:48
with ReferenceTxInsScriptsInlineDatumsSupportedInEra because these three
features become available at the same time. Having separate types for
these features adds unnecessary boilerplate.
@Jimbo4350 Jimbo4350 force-pushed the jordan/cardano-api-reference-inputs branch from c2307ab to 95f1d8c Compare April 20, 2022 14:51
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tx-generator wise

@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 20, 2022
3804: Add reference transaction inputs to cardano-api r=Jimbo4350 a=Jimbo4350



3807: Fix scripts/byron-to-alonzo/mkfiles.sh script r=newhoggy a=newhoggy

to work on new versions of cardano-cli which do not create an alonzo genesis file

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
Co-authored-by: John Ky <john.ky@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 20, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, denisshevchenko, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Jimbo4350
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 20, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit c72911f into master Apr 20, 2022
@iohk-bors iohk-bors bot deleted the jordan/cardano-api-reference-inputs branch April 20, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants