Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cardano-node-macos hydraJob expression for aarch64-darwin #5628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ch1bo
Copy link
Contributor

@ch1bo ch1bo commented Jan 8, 2024

Enable the flake output building a "binary release" of cardano-node and other binaries also on aarch64-darwin builds.

We use this downstream to build cardano-node and cardano-cli distributable executables for our users. See also cardano-scaling/hydra#1233

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. -> Not needed
  • Any changes are noted in the CHANGELOG.md for affected package. -> Not needed
  • The version bounds in .cabal files are updated -> Not needed
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Feb 23, 2024
@ch1bo ch1bo requested review from a team March 1, 2024 13:33
@github-actions github-actions bot removed the Stale label Mar 2, 2024
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this PR. There are hydra failures, which may be fixed on master already.

@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from 3e47920 to bd31f80 Compare March 19, 2024 17:36
@ch1bo ch1bo requested review from a team as code owners March 19, 2024 17:36
Copy link

github-actions bot commented May 4, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 4, 2024
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@github-actions github-actions bot removed the Stale label May 5, 2024
@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from bd31f80 to eae4325 Compare May 23, 2024 10:35
@ch1bo ch1bo enabled auto-merge May 23, 2024 10:36
@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from eae4325 to 9b91e8a Compare June 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants