Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate serialiseTxLedgerCddl #5867

Closed
wants to merge 1 commit into from

Conversation

palas
Copy link
Contributor

@palas palas commented May 29, 2024

Description

This PR fixes compilation issues and updates tests as a consequence of the deprecation of serialiseTxLedgerCddl in cardano-api. It serves as a test previous to merging this PR.

Context

cardano-api

cardano-cli

cardano-node

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@palas palas self-assigned this May 29, 2024
@palas palas requested a review from a team as a code owner May 29, 2024 20:09
@palas palas changed the title Deprecate serialise tx ledger cddl testing Deprecate serialiseTxLedgerCddl May 29, 2024
@palas
Copy link
Contributor Author

palas commented Jul 8, 2024

Already done by PR: #5879

@palas palas closed this Jul 8, 2024
@palas palas deleted the deprecate-serialiseTxLedgerCddl-testing branch July 8, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants