consensus: rename TriggerHardForkNever to TriggerHardForkNotDuringThisExecution #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrisby
force-pushed
the
nfrisby/hfc-fix-confusing-name
branch
2 times, most recently
from
39668a4
to
6b1ca66
Compare
amesgen
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Thanks, this is a strict improvement, and might even have prevented bugs such as the one fixed by IntersectMBO/ouroboros-network#3754
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Simple.hs
Outdated
Show resolved
Hide resolved
nfrisby
force-pushed
the
nfrisby/hfc-fix-confusing-name
branch
2 times, most recently
from
1bc81a8
to
286a4c6
Compare
nfrisby
changed the title
nfrisby
force-pushed
the
nfrisby/hfc-fix-confusing-name
branch
from
286a4c6
to
e78d38b
Compare
…sExecution We have found that the "never" wording was leading us to believe that this setting was instructing the HFC to assume that the era never ended. That is explicitly not the case (see UnsafeIndefiniteSafeZone instead).
amesgen
force-pushed
the
nfrisby/hfc-fix-confusing-name
branch
from
e78d38b
to
f80c43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the single commit's message.