Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce NodeToNodeV_14 #4986

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Introduce NodeToNodeV_14 #4986

merged 4 commits into from
Oct 11, 2024

Conversation

crocodile-dentist
Copy link
Contributor

Description

No changes in this version, it will be used to identify adoption rate of Chang +1 HF.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@crocodile-dentist crocodile-dentist requested a review from a team as a code owner October 9, 2024 15:24
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/introduce-nodetonodev_14 branch 2 times, most recently from 83d3537 to cf2c957 Compare October 9, 2024 21:17
karknu
karknu requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you should add support for V14 to cardano-ping too.

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/introduce-nodetonodev_14 branch 2 times, most recently from 1192201 to c89cb93 Compare October 10, 2024 11:19
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/introduce-nodetonodev_14 branch from c89cb93 to 7bd3e29 Compare October 10, 2024 12:22
karknu
karknu approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coot
coot approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crocodile-dentist crocodile-dentist added this pull request to the merge queue Oct 11, 2024
Merged via the queue into master with commit 6ff4120 Oct 11, 2024
11 of 12 checks passed
@crocodile-dentist crocodile-dentist deleted the mwojtowicz/introduce-nodetonodev_14 branch October 11, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@karknu karknu karknu approved these changes

Assignees

@crocodile-dentist crocodile-dentist

Labels
None yet
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crocodile-dentist @coot @karknu