Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IIFE #23

Closed
felquis opened this issue Jun 24, 2015 · 1 comment
Closed

Use IIFE #23

felquis opened this issue Jun 24, 2015 · 1 comment
Labels
enhancement in progress style-guide
Milestone
1.0.0-beta.1

Comments

@felquis
Copy link
Member

felquis commented Jun 24, 2015

We follow this style guide https://github.com/johnpapa/angular-styleguide#javascript-closures

But our code doesn't use IIFEs yet
@felquis felquis added this to the 1.0.0-beta.1 milestone Jun 24, 2015
This was referenced Jun 24, 2015
Closed
Closed
@giorgiofellipe giorgiofellipe mentioned this issue Jun 26, 2015
Merged
@felquis
Copy link
Member Author

felquis commented Jun 28, 2015

There's a problem with JSCS(I hope it's with me), if we use disallowAnonymousFunctions we also can't use anonymous functions in IIFE

Does anyway know how could we check if the files use IIFEs and also avoid Anonymous Functions inside IIFEs?

@felquis felquis mentioned this issue Jun 29, 2015
Closed
felquis added a commit that referenced this issue Jul 4, 2015
@felquis
Add script inject and wrapps all files into IIFEs
4097694 
In this way, we could ensure named functions and ensure every file has
their own scope.

related to #23 closes #24
felquis added a commit that referenced this issue Jul 4, 2015
@felquis
Removing all IIFEs and fixing style-guide warnings
4dfbe48 
related to #23 #27
@felquis felquis closed this as completed in 2dda1f7 Jul 4, 2015
felquis added a commit that referenced this issue Jul 4, 2015
@felquis
Update config.allStaticFiles ignoring JS files
3432c37 
related to #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement in progress style-guide
Projects
None yet
Milestone
1.0.0-beta.1
Development

No branches or pull requests
2 participants
@felquis @giorgiofellipe