Fixes #1386 - not being able to serialize IReadonlyCollection<int> while using CollectionStorage.AsArray #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile using CollectionStorage.AsArray
|
So first off, big kudos for the test coverage. Other than that, as long as the tests all pass, I can't see any issue with the change. |
…donlycollection_with_integers_and_private_setter to better reflect test case scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the description - see more details in #1386
Besides providing the fix and adding test for the described case, I updated inner collection queries tests to be sure that this case won't be missed again.