-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix signal scaling and add background fit to fitsignal plots #78
Conversation
Instead of introducing a new input parameter to request the scaled background signal, it might be better to just return both unscaled and scaled background in the FitResult structure. Same for the overall signal. That is the easiest from the user perspective, as they don't have to remember yet another input parameter, and they can just look at FitResult and then pick what they want for plotting etc. |
This would be an excellent idea, will do so. Indeed it is easier to search for outputs than to prepare inputs and options for certain behavior. It would also go in the way of a recent request:
|
…ncertainty, remove scaledBckg option
The recent changes should now close #86 as well. |
This PR fixes issues related to the
plot()
method offitsignal
's output. The experimental dipolar signals and the corresponding fit were being plotting with different scales seeming like one of the two was not being plotted.Potentially closes #74
Changelog:
plot()
method.fit.B
output