-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Transition to Missing #200
Merged
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d2bcb1f
table.jl -> indexedtable.jl
joshday 643b4a3
tables integration
joshday c74f92f
uncomment tests
joshday 86b64ba
sneak some cleanup into the PR
joshday 89e08eb
fix typo
joshday 493845d
wip
joshday b6c6bc5
wip
joshday 0f6b8c3
got out of sync...merge conflicts
joshday 99b1c68
cleanup
joshday cce84dd
get started, comment out tests with DataValue/NA
joshday 33a8a36
remove DataValue/NA from tests
joshday 5346478
fix reshape and table ==
joshday 28d757c
dropna -> dropmissing
joshday aea6c72
no more DataValues
joshday 6e71b60
fix ==
joshday 9e89000
test cleanup, use fallback array method for == with Columns
joshday 76b2826
cleanup
joshday 64b0200
fix tests on 0.7
joshday 1022c8a
don't export dropna
joshday 662f3f3
cleanup, add Type SpecialSelector
joshday 5470db5
address some comments
joshday 53936df
remove dropmissing(::AbstractVector) method
joshday 6f11e8f
export dropna for deprecation period
joshday fb8d138
== and isequal in the right places
joshday 2e4d098
use convert in join
joshday File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ WeakRefStrings 0.4.4 | |
TableTraits 0.3.0 | ||
TableTraitsUtils 0.2.0 | ||
IteratorInterfaceExtensions 0.1.0 | ||
DataValues | ||
Tables |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification here