Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoMerge: temporarily disable the "Require [compat] for stdlib dependencies" feature" #540

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jan 29, 2024

Follow-up to #516

Once we are ready to re-enable the "Require [compat] for stdlib dependencies" feature", we just need to change the following value from false to true:

const _AUTOMERGE_REQUIRE_STDLIB_COMPAT = false

@DilumAluthge
Copy link
Member Author

After we merge this PR (and make a new release of RegistryCI), we can deploy the latest version of RegistryCI to the General registry.

apply_compat_requirement = !is_jll_name(name)
else
debug_msg = "Found a new (non-stdlib non-JLL) dependency: $(name)"
apply_compat_requirement = !is_jll_name(name) && !is_julia_stdlib(name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this function exists anymore, we'd need to restore it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Restored in 46b5d70

Copy link
Member

@ericphanson ericphanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DilumAluthge DilumAluthge added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit 7589e58 Jan 29, 2024
11 checks passed
@DilumAluthge DilumAluthge deleted the dpa/temp-disable-stdlib-compat branch January 29, 2024 17:50
ericphanson referenced this pull request Jan 30, 2024
* Upgrade to Documenter v1

* Update make.jl

* Update Project.toml

---------

Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants