Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ga/Ja_safe flags and mittleff clean-up #108

Merged
merged 10 commits into from
Apr 11, 2021
Merged

Ga/Ja_safe flags and mittleff clean-up #108

merged 10 commits into from
Apr 11, 2021

Conversation

akabla
Copy link
Member

@akabla akabla commented Apr 11, 2021

No description provided.

Copy link
Member

@moustachio-belvedere moustachio-belvedere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added two minor comments

src/datagen.jl Show resolved Hide resolved
test/datagen.jl Outdated Show resolved Hide resolved
src/RHEOS.jl Show resolved Hide resolved
src/modeldatabase.jl Show resolved Hide resolved
test/benchmarks.jl Show resolved Hide resolved
@moustachio-belvedere
Copy link
Member

Only other remnant of mittleff is probably something in the readme

@akabla
Copy link
Member Author

akabla commented Apr 11, 2021

Indeed - just remove the embedded dependency comment from the README.

codecov is very unhappy now...

@akabla akabla changed the title Ga/Ja_safe flags clean-up done Ga/Ja_safe flags and mittleff clean-up Apr 11, 2021
@akabla akabla merged commit 57732d1 into master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants