Expose propellantStability directly without rounding #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces GetPropellantProbability/GetUllageProbability to get the rounded version that forces veryStable to 100% (couldn't think of a better name, even though this isn't really the proper probability since the exponent isn't applied). This lets MJ 'see' values between 0.996 and 1.0 Didn't get this compiling yet because of all the RF deps and ROUtils in particular so be a little careful before merging. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
NathanKell
requested changes
Nov 9, 2023
|
While we're waiting on the CKAN folks to merge the PR to put ROUtils on netkan, it does exist on github if you want to grab it (KSP-RO/ROUtils). But the code certainly looks like it'd build. :D And per the review I'd just push the Pow down into the function so it's not a lie. |
|
(Thanks for doing the debugging and PR work btw! 👍 ) |
|
Okay I made GetPropellantProbability() really be the probability. This change now actually updates the PAW to be the probability rather than stability--but that feels like the right thing to expose to the ultimate end user? Also downloaded ROUtils release and validated it compiles, but now haven't tested anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces GetPropellantProbability/GetUllageProbability to get the rounded version that forces veryStable to 100% (couldn't think of a better name, even though this isn't really the proper probability since the exponent isn't applied).
This lets MJ 'see' values between 0.996 and 1.0
Didn't get this compiling yet because of all the RF deps and ROUtils in particular so be a little careful before merging.