Always recalculate seed in prelaunch #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
Gonna merge this because it's better than what we have, but it's worth pointing out that this also means if you quicksave while in prelaunch and then quickload your seed will get clobbered, which would be extra weird if you had started an engine already. (This also applies if you start an engine, throttle down, change scenes, and then go back to the craft). Probably better to catch the revert request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is that Revert To Launch will use a state that is captured after the random got seeded. This means that all reverts get the exact same engine performance. This in turn means that people may get overly confident in their design being able to cope with thrust offsets and having the performance needed.