State Breaking: Backport fix to prevent failed transactions from commiting state when block gas limit is reached #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that fail do to block gas limits from committing state
nddeluca
commented
Jan 14, 2022
| }() | ||
| } | ||
| if mode == runTxModeDeliver { | ||
| defer consumeBlockGas() |
There was a problem hiding this comment.
This defer behavior is unchanged and still runs if we do not make it to runMessages for a transaction
nddeluca
commented
Jan 14, 2022
| if mode == runTxModeDeliver { | ||
| blockGasConsumed := false | ||
| consumeBlockGas := func() { | ||
| if !blockGasConsumed { |
There was a problem hiding this comment.
This check ensures block gas is only consumed once
nddeluca
commented
Jan 14, 2022
| @@ -678,6 +683,8 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte) (gInfo sdk.GasInfo, re | |||
| // Result if any single message fails or does not have a registered Handler. | |||
| result, err = app.runMsgs(runMsgCtx, msgs, mode) | |||
| if err == nil && mode == runTxModeDeliver { | |||
| consumeBlockGas() | |||
There was a problem hiding this comment.
This is the main fix -- gas is consumed before calling msCache.Write(), ensuring a panic is thrown when if the transaction consumes more than the block limit
karzak
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of @yihuang's work in cosmos#10814.