-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemente client.stream() #34
Conversation
serfclient/connection.py
Outdated
@@ -2,6 +2,7 @@ | |||
import sys | |||
import msgpack | |||
import resource | |||
import queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being used here? It looks like it's breaking the build in a few places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, it's not, removing it.
@KushalP do you know how I would fix https://travis-ci.org/KushalP/serfclient-py/jobs/258695208 ? I've just been doing Python for a few weeks and this looks like a backwards compatibility issue? |
@olalonde you're doing great so far! Python 2 and 3 have a few odd differences and it's worth learning them and being able to spot them over time. In the case of these tests, it's worth picking one of the failing tests in question (2.6 or 3.3) and working from there. pdbA useful tool to learn to use is With it, you can set a trace point and when you run some Python code a REPL will appear allowing you to get at any of the values that are in scope. Here's a small example: import pdb
a = 1
pdb.set_trace()
# I can run this code, and a REPL will appear here, allowing me to read the value of `a`. You can use this method, at the line before your test fails, to examine what the state of each of your values are, so that you can better debug this issue. -v (verbose mode)As the test line in question says, you can use virtualenvTo test multiple versions of Python locally, a common practice is to use virtualenv. It's a package that allows you to (locally) set up multiple Python versions and change between them. That should help you better understand what's going on here. Let me know if you're still having trouble getting to the bottom of this. |
Thanks for the tips :) I fixed the tests that were failing. |
Excellent work! Can you squash the fix into the previous commit please? Then I'll be happy to merge this and get a release out. |
Just did, thanks 👍 |
Thank you! I'll try to get a release made later this week. I'm not near my machine which has the relevant GPG keys. |
No description provided.