first implementation #1
Conversation
go.mod
Outdated
| @@ -0,0 +1,5 @@ | |||
| module github.com/go-misc/async-retry | |||
There was a problem hiding this comment.
[nits]
How about github.com/Kyash/async-retry as a module name?
I don't have a strong opinion, so I'll leave it to you to decide if you want to modify it or not.
There was a problem hiding this comment.
This is just a trash made when I developed at local environment. Thanks!
cf84aa6
There was a problem hiding this comment.
Thanks for the quick fix!
Please also fix the sample code listed in the README
https://github.com/Kyash/async-retry/blob/first-impl/README.md?plain=1#L26
| a.mu.Lock() | ||
| select { | ||
| case <-a.shutdownChan: | ||
| return InShutdownErr |
There was a problem hiding this comment.
mu.Unlock() is not called when a.shutdownChan is already closed.
This means that if a asyncRetry.Do is called twice on asyncRetry resource that has already been shutdown, the second call will fail to acquire a mu.Lock() and will result in a deadlock.
I think it should be fixed.
There was a problem hiding this comment.
Thx!
You are right!
I've just submitted for this bug: #4
What I did
Please read README and test codes to understand features and interfaces.
Feel free to ask questions if you have.
I found a bug after submitting this PR, I'll fix in a new PR!
see: #2
Next Action
I'll submit as new PRs for features below soon.
Fix bug of github.com/avast/retry-go and submit PR. If merged, I'll update version.[Update] done at 6eadc4e