Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix as_remote conditions #19

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jan 13, 2023

No description provided.

Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3e1e6f6

@dr-orlovsky
Copy link
Contributor

NB: related to LNP-WG/lnp-node#68 (comment)

@dr-orlovsky dr-orlovsky merged commit 42de4d1 into LNP-WG:master Jan 17, 2023
@dr-orlovsky
Copy link
Contributor

This had broken CI tests: either this is ok (since the tests were wrong) or the change is not valid. Can you pls see
https://github.com/LNP-WG/lnp-core/actions/runs/3938781953/jobs/6737872327#step:4:236

@dr-orlovsky dr-orlovsky added this to the v0.9.0 milestone Jan 18, 2023
@crisdut crisdut deleted the fix/as_remote branch January 26, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants