ClusterTimeSimulation #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think it would be a good idea to run a formatter like JuliaFormatter.jl over the code and also add some tests for MSD. (You can just copy the starting conditions of MQD and then calculate the expected values by hand)
test/test_Simulation.jl
Outdated
Comment on lines
34
to
41
| world2 = World( | ||
| v0=1.0, | ||
| n_dogs=100, | ||
| boxsize=50.0, | ||
| motion=BrownianMotion(noise=0.5, friction=1.0), | ||
| sheeps=DenseSheeps(20, n_sheeps=20), | ||
| ) | ||
|
|
There was a problem hiding this comment.
generally speaking it is not a good idea to have more collectors than items, since you might end up in the situation where all items are picked up and in the best case the simulation will just get stuck in that state
|
For posteriority:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6 closes #18
Fix #10