Bumb requirement version for dacite GREATER than 1.8.0 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, thats a duplicate to a merged reqeust. |
Hi @LaggAt , I think this PR is different. @sdrapha is asking to make the requirement 1.8.0 OR HIGHER. The PR you put in 124 is saying requires exactly 1.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar PR to the other one already posted here. only difference though is, since I started to troubleshoot my problem with the Roborock integration, there was already a newer version of Dacite, the 1.8.1.
HOWEVER, I did tried to explicitly ask for the newer version, which was also giving me some problems with roborock for some weird reason.
So the actual fix now, is to ask on the requirements for a version GREATER than 1.8.0
>=1.8.0instead of pinning any specific version==. And letting the system deal with. I actually get the 1.8.1 installed anyway when I check withpip show dacite.This way now, I have everything working, Govee and Roborock, everytime, surviving reboots.