Also keep route grid working when no static content is linked #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1,3 @@ | |||
| {{ data.title }} | |||
| {% if data is not same as(null) %} | |||
There was a problem hiding this comment.
(% if data is not null %} - doesn't work?
There was a problem hiding this comment.
Hm, might be. This is what I'm also using :) But it seems to work: https://twig.sensiolabs.org/doc/2.x/tests/null.html :)
|
Adjusted it, your suggestion should work :) |
|
Thanks Stefan! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly it was an issue on my fixtures side, as I forgot to link a StaticContent object to the Route object I was importing. But, as soon as a StaticContent seems gone and the Route cannot find the relation anymore, the grid errors that the
data.titleis not available (data is null). It doesn't harm to add this if statement I think, as it helps to keep the grid running even though there is some content missing somewhere.