EIP-712 amount-join support with unknown token #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
fix/apa/eip712_amount_join_unknown_token
branch
4 times, most recently
from
5f4b6a1
to
23cd6e0
Compare
apaillier-ledger
changed the title
cedelavergne-ledger
previously approved these changes
Sep 10, 2024
apaillier-ledger
force-pushed
the
fix/apa/eip712_amount_join_unknown_token
branch
from
23cd6e0
to
f3b4073
Compare
cedelavergne-ledger
previously approved these changes
Sep 10, 2024
…-joins Client now sends token information for EIP 712 amount-joins only when needed instead of all at the beginning of the flow.
apaillier-ledger
force-pushed
the
fix/apa/eip712_amount_join_unknown_token
branch
from
f3b4073
to
6efc9cb
Compare
apaillier-ledger
deleted the
fix/apa/eip712_amount_join_unknown_token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now instead of considering this an error, shows the amount-join with the little information it has like it does for transactions (with
???for ticker).Changes include