Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in Value.php #152

Closed
cxj opened this issue May 6, 2017 · 7 comments
Closed

Syntax error in Value.php #152

cxj opened this issue May 6, 2017 · 7 comments

Comments

@cxj
Copy link
Contributor

cxj commented May 6, 2017

Line 150 of src/Parser/Value.php has a syntax error.

$ php -l vendor/level-2/transphporm/src/Parser/Value.php

Parse error: syntax error, unexpected '?' in vendor/level-2/transphporm/src/Parser/Value.php on line 150
@solleer
Copy link
Collaborator

solleer commented May 6, 2017

Are you using php7?

@cxj
Copy link
Contributor Author

cxj commented May 6, 2017

Could we get a stable snapshot tagged or something of more recent code than the last release? I've been using the HEAD of master to get what I needed, and it was working until I just ran composer update tonight which grabbed the above syntax error. Thanks!

@cxj
Copy link
Contributor Author

cxj commented May 6, 2017

PHP 5.6.27 at the moment. Will be migrating to PHP 7 in the next month or two.

@cxj
Copy link
Contributor Author

cxj commented May 6, 2017

If you're going to require PHP 7, you should update the requirements in the composer.json file as well as in the documentation.

@cxj
Copy link
Contributor Author

cxj commented May 6, 2017

It would be ideal to have a branch or release prior to changes which require PHP 7.

@TRPB
Copy link
Member

TRPB commented May 26, 2017

Yes, you're right. I'll refactor it so php7 isn't required, there's no real reason this can't be expressed without the more convenient shorthand notation.

@cxj
Copy link
Contributor Author

cxj commented May 26, 2017

Fantastic. Thanks much!

garrettw added a commit to garrettw/Transphporm that referenced this issue May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants