Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process launchers #11643

Merged
merged 40 commits into from
Feb 17, 2022
Merged

Add process launchers #11643

merged 40 commits into from
Feb 17, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 27, 2022

What does this PR do?

Fixes #10985

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @kaushikb11 @rohitgr7 @justusschock @awaelchli @akihironitta

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review, great work so far

pytorch_lightning/strategies/executors/ddp.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/executors/ddp.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/executors/ddp.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/executors/ddp.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/executors/ddp.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 changed the title Add process executors Add process launchers Feb 2, 2022
@rohitgr7 rohitgr7 added accelerator: tpu Tensor Processing Unit feature Is an improvement or enhancement strategy strategy: ddp DistributedDataParallel strategy: ddp spawn labels Feb 3, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Feb 3, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review February 3, 2022 20:19
rohitgr7 and others added 2 commits February 17, 2022 20:53
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! @rohitgr7 @awaelchli

Looking forward to those follow-ups

pytorch_lightning/strategies/launchers/spawn.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/strategy.py Show resolved Hide resolved
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 17, 2022
awaelchli and others added 2 commits February 17, 2022 21:34
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will follow up with clean up for #10895

@rohitgr7
Copy link
Contributor Author

thanks, @awaelchli for the discussions for this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit feature Is an improvement or enhancement ready PRs ready to be merged strategy: ddp DistributedDataParallel strategy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface for Process Creation (DDPSpawn vs. DDP)
6 participants