Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra changes to lightning-lite #14950

Merged
merged 11 commits into from
Sep 30, 2022

Conversation

Atharva-Phatak
Copy link
Contributor

What does this PR do?

This PR adds the same changes #11617 to lightning lite launcher. This PR addresses the issue #14799 .

Fixes #14799

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 29, 2022
@awaelchli awaelchli added 3rd party Related to a 3rd-party fabric lightning.fabric.Fabric feature Is an improvement or enhancement labels Sep 29, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #14950 (21b60c4) into master (498cb60) will increase coverage by 2%.
The diff coverage is 47%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #14950     +/-   ##
=========================================
+ Coverage      84%      86%     +2%     
=========================================
  Files         395      276    -119     
  Lines       28850    21100   -7750     
=========================================
- Hits        24206    18052   -6154     
+ Misses       4644     3048   -1596     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One minor comment.

And I will take a look at the tests later on.

@carmocca carmocca added the community This PR is from the community label Sep 29, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 30, 2022
@awaelchli awaelchli merged commit fdcb5cc into Lightning-AI:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party community This PR is from the community fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring Hydra improvements to Lite
3 participants