Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/17412 lr finder max val batches #17636

Merged

Conversation

baskrahmer
Copy link
Contributor

What does this PR do?

Resets the CombinedLoader attribute of the eval loop to trigger a re-initialization with the correct val_limit batches.

Fixes #17412

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 15, 2023
@Borda Borda enabled auto-merge (squash) May 17, 2023 17:27
@awaelchli awaelchli added community This PR is from the community tuner labels May 18, 2023
@awaelchli awaelchli added this to the 2.0.x milestone May 18, 2023
@Borda Borda merged commit 2ce9758 into Lightning-AI:master May 18, 2023
@awaelchli awaelchli added the bug Something isn't working label May 18, 2023
@mergify mergify bot added the ready PRs ready to be merged label May 18, 2023
Borda pushed a commit that referenced this pull request Jun 2, 2023
Borda pushed a commit that referenced this pull request Jun 2, 2023
lantiga pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged tuner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LearningRateFinder defining max validation batches for entire training loop
3 participants