-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overlapping samples in DDP when no global seed is set #17713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
bug
Something isn't working
data handling
Generic data-related topic
strategy: ddp
DistributedDataParallel
labels
May 28, 2023
for more information, see https://pre-commit.ci
awaelchli
changed the title
Fix overlapping samples in DDP when no global seed is set
WIP: Fix overlapping samples in DDP when no global seed is set
May 28, 2023
awaelchli
requested review from
carmocca,
justusschock and
williamFalcon
as code owners
May 28, 2023 22:10
justusschock
approved these changes
May 28, 2023
awaelchli
changed the title
WIP: Fix overlapping samples in DDP when no global seed is set
Fix overlapping samples in DDP when no global seed is set
May 28, 2023
Borda
approved these changes
May 29, 2023
carmocca
reviewed
May 29, 2023
awaelchli
force-pushed
the
bugfix/dist-sampler-shuffle-true
branch
2 times, most recently
from
May 29, 2023 20:24
e8be589
to
64763e8
Compare
carmocca
approved these changes
May 29, 2023
Borda
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 53815e6)
lantiga
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 53815e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
data handling
Generic data-related topic
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes an edge case when the user wants to run with
shuffle=True
, no global seed set, accelerator="ddp". On master, this situation results in overlapping data. Reported by user Turab Iqbal on Slack (thanks!).Repro:
Note:
cc @Borda @justusschock @awaelchli