-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable loading legacy checkpoints that pickled the _FaultToleranceMode
enum
#18094
Merged
awaelchli
merged 4 commits into
master
from
bugfix/checkpoint-migration-fault-tolerancemode
Jul 18, 2023
Merged
Enable loading legacy checkpoints that pickled the _FaultToleranceMode
enum
#18094
awaelchli
merged 4 commits into
master
from
bugfix/checkpoint-migration-fault-tolerancemode
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
bug
Something isn't working
checkpointing
Related to checkpointing
fun
Staff contributions outside working hours - to differentiate from the "community" label
labels
Jul 17, 2023
awaelchli
requested review from
carmocca,
justusschock and
williamFalcon
as code owners
July 17, 2023 23:35
carmocca
approved these changes
Jul 18, 2023
Borda
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
checkpointing
Related to checkpointing
fun
Staff contributions outside working hours - to differentiate from the "community" label
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #17260
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @awaelchli