-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests that cause CLI argparse errors on Python 3.11.9 #19756
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19756 +/- ##
==========================================
- Coverage 82% 53% -29%
==========================================
Files 424 416 -8
Lines 34919 34766 -153
==========================================
- Hits 28628 18445 -10183
- Misses 6291 16321 +10030 |
What does this PR do?
Python 3.11.9 was released recently and is picked up by our CI. It had a breaking change that jsonargparse relied on.
https://github.com/Lightning-AI/pytorch-lightning/actions/runs/8633090509/job/23665307586?pr=19755
We can undo this PR once jsonargparse has released the fix:
omni-us/jsonargparse#484
📚 Documentation preview 📚: https://pytorch-lightning--19756.org.readthedocs.build/en/19756/
cc @Borda