Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo scrict -> strict in types.py #19998

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

elmuz
Copy link
Contributor

@elmuz elmuz commented Jun 20, 2024

What does this PR do?

This PR fixes a typo in LRSchedulerConfigType.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19998.org.readthedocs.build/en/19998/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53%. Comparing base (1e83a1b) to head (0967842).
Report is 86 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1e83a1b) and HEAD (0967842). Click for more details.

HEAD has 444 uploads less than BASE
Flag BASE (1e83a1b) HEAD (0967842)
python3.10 42 12
cpu 125 22
lightning 77 16
pytest 59 2
gpu 4 2
lightning_fabric 10 0
pytorch_lightning 28 8
python3.8 34 6
examples 6 0
app 6 0
tpu 1 0
pytorch2.0 35 11
pytest-full 71 22
pytorch2.1 18 5
python3.11 18 4
pytorch2.3 9 3
pytorch2.2 9 3
lightning_app 8 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19998      +/-   ##
==========================================
- Coverage      84%      53%     -31%     
==========================================
  Files         426      418       -8     
  Lines       35293    35140     -153     
==========================================
- Hits        29628    18720   -10908     
- Misses       5665    16420   +10755     

@awaelchli awaelchli changed the title fix: typo scrict -> strict in types.py Fix typo scrict -> strict in types.py Jun 20, 2024
@awaelchli awaelchli added this to the 2.3.x milestone Jun 20, 2024
@awaelchli awaelchli added the bug Something isn't working label Jun 20, 2024
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@awaelchli awaelchli merged commit cec6ae1 into Lightning-AI:master Jun 20, 2024
96 checks passed
@mergify mergify bot added the ready PRs ready to be merged label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants