-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyTorch 2.4 tests #20079
Merged
Merged
Update PyTorch 2.4 tests #20079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
labels
Jul 13, 2024
awaelchli
requested review from
lantiga,
Borda,
tchaton and
justusschock
as code owners
July 13, 2024 01:07
awaelchli
added
the
fun
Staff contributions outside working hours - to differentiate from the "community" label
label
Jul 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20079 +/- ##
========================================
Coverage 90% 91%
========================================
Files 266 266
Lines 22961 22961
========================================
+ Hits 20690 20794 +104
+ Misses 2271 2167 -104 |
Borda
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a few tests running on PyTorch 2.4. See #20010 #20028.
For the tests that raise FutureWarning internally in PyTorch, I've opened an issue on the PyTorch repo: pytorch/pytorch#130658
cc @carmocca @justusschock @awaelchli