GetStateEx support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code seems good. I'm not sure what you mean by "Not Option<>" though |
|
Existing code treat some external functions Option<T>, this one is not, meaning if loading Ordinal 100 failed the program return Err, code is tested |
|
If it's an Ex function that didn't exist in some early version of XInput, then it needs to be optionally loaded. Using option or not is about compatibility back to old XInput versions, not a concern that the functions will go away in a future version. |
|
GetStateEx wasn't introduced until XInput 1.3. It's also an undocumented function exported by ordinal only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not Option<>, I believe this will never get removed