Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Enhancement making the system token a one-time token. #178

Merged
merged 1 commit into from
Nov 6, 2017
Merged

API Enhancement making the system token a one-time token. #178

merged 1 commit into from
Nov 6, 2017

Conversation

abellotti
Copy link
Member

  • X_MIQ_TOKEN can now only be used once.
  • Added spec test verifying the OTP check and unauthorized error.

@abellotti
API Enhancement making the system token a one-time token.
5958775 
- X_MIQ_TOKEN can now only be used once.
- Added spec test verifying the OTP check and unauthorized error.
@abellotti abellotti mentioned this pull request Nov 6, 2017
Closed
@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2017

Checked commit abellotti@5958775 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

gtanzillo
gtanzillo approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@gtanzillo gtanzillo added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 6, 2017
@gtanzillo gtanzillo merged commit e8c018b into ManageIQ:master Nov 6, 2017
simaishi pushed a commit that referenced this pull request Nov 6, 2017
@gtanzillo @simaishi
Merge pull request #178 from abellotti/api_onetime_system_token
4dd570a 
API Enhancement making the system token a one-time token.
(cherry picked from commit e8c018b)
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 4dd570a9801649d8749a3c37f14472db46aa34f1
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Nov 6 13:15:52 2017 -0500

    Merge pull request #178 from abellotti/api_onetime_system_token
    
    API Enhancement making the system token a one-time token.
    (cherry picked from commit e8c018b2bc735b90bd0644c1ec8e0c40fea0af27)

@carbonin carbonin mentioned this pull request Nov 20, 2017
Merged
abellotti added a commit to abellotti/manageiq-api that referenced this pull request Nov 20, 2017
@abellotti
Revert "Merge pull request ManageIQ#178 from abellotti/api_onetime_sy…
28b92fa 
…stem_token"

This reverts commit e8c018b, reversing
changes made to 9a2767c.
andyvesel pushed a commit to andyvesel/manageiq-api that referenced this pull request Nov 22, 2017
@abellotti @andyvesel
Revert "Merge pull request ManageIQ#178 from abellotti/api_onetime_sy…
52df44f 
…stem_token"

This reverts commit e8c018b, reversing
changes made to 9a2767c.
@abellotti abellotti deleted the api_onetime_system_token branch November 22, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abellotti @miq-bot @simaishi @gtanzillo