use request_admin_user? #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kicking |
kbrock
force-pushed
the
super_admin_feature
branch
from
3a74b36
to
f929c18
Compare
kbrock
force-pushed
the
super_admin_feature
branch
from
f929c18
to
4e4546e
Compare
the generic admin is phased out. Instead we are using the actual property. `request_admin_user?` is a shortcut for request superadmin privs https://bugzilla.redhat.com/show_bug.cgi?id=1090627
kbrock
force-pushed
the
super_admin_feature
branch
from
4e4546e
to
bf3b802
Compare
|
Checked commits kbrock/manageiq-api@161ed6f~...bf3b802 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
abellotti
approved these changes
Jun 4, 2018
|
Thanks @kbrock for fixing this. LGTM!! 👍 |
This was referenced Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on:Remove generic
admin_user?check and replace withrequest_admin_user?https://bugzilla.redhat.com/show_bug.cgi?id=1090627