Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event_streams as subcollection of the physical resources #424

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Add event_streams as subcollection of the physical resources #424

merged 1 commit into from
Jul 25, 2018

Conversation

CharlleDaniel
Copy link
Member

@CharlleDaniel CharlleDaniel commented Jul 18, 2018 •
edited
Loading

This PR is able to:

  • Add event_streams as subcollection of the physical resources as:
    • physical_server endpoint
         get /physical_servers/id/event_streams
     get /physical_servers/id/event_streams/id
    • physical_chassis endpoint
    • physical_switches endpoint

Dependes on: ManageIQ - manageiq 17661 - MERGED

@CharlleDaniel CharlleDaniel changed the title Add event_streams as subcollection of the physical resources [WIP] Add event_streams as subcollection of the physical resources Jul 18, 2018
@miq-bot miq-bot added the wip label Jul 18, 2018
@CharlleDaniel CharlleDaniel changed the title [WIP] Add event_streams as subcollection of the physical resources Add event_streams as subcollection of the physical resources Jul 18, 2018
@miq-bot miq-bot removed the wip label Jul 18, 2018
@CharlleDaniel CharlleDaniel changed the title Add event_streams as subcollection of the physical resources [WIP] Add event_streams as subcollection of the physical resources Jul 19, 2018
@miq-bot miq-bot added the wip label Jul 19, 2018
@Fryguy
Copy link
Member

Fryguy commented Jul 19, 2018

@bdunne Please review.

bdunne
bdunne requested changes Jul 20, 2018
View reviewed changes
config/api.yml Outdated
@@ -1745,9 +1745,11 @@
:identifier: physical_chassis
:options:
- :collection
- :subcollection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this means that physical_chassis can be a subcollection of something else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yap, sorry I removed this

config/api.yml Outdated
@@ -1762,6 +1764,14 @@
:post:
- :name: refresh
:identifier: physical_chassis_refresh
:event_streams_subcollection_actions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this belongs under the event_streams as subcollection_actions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

config/api.yml Outdated
:get:
- :name: read
:identifier: event_streams_show_list
:event_streams_subresource_actions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this belongs under the event_streams as subresource_actions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

spec/requests/physical_servers_spec.rb Outdated
@@ -1,3 +1,5 @@
require 'pry'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove debugging tools before unwip.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@CharlleDaniel CharlleDaniel force-pushed the add_event_stream_subcollection branch 2 times, most recently from 4c7580f to c806c43 Compare July 25, 2018 12:41
@CharlleDaniel
Copy link
Member Author

@bdunne Thank you about your review, but could you review again ?

@CharlleDaniel CharlleDaniel changed the title [WIP] Add event_streams as subcollection of the physical resources Add event_streams as subcollection of the physical resources Jul 25, 2018
@miq-bot miq-bot removed the wip label Jul 25, 2018
@CharlleDaniel CharlleDaniel force-pushed the add_event_stream_subcollection branch 3 times, most recently from 6cb2d0d to bffaf3c Compare July 25, 2018 13:49
@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2018

Checked commit CharlleDaniel@bffaf3c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 0 offenses detected
Everything looks fine. 👍

bdunne
bdunne approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, @abellotti can you take a look?

@abellotti abellotti added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 25, 2018
@abellotti abellotti self-assigned this Jul 25, 2018
@abellotti
Copy link
Member

Thanks @CharlleDaniel for the API Enhancement, this LGTM!! 👍

@abellotti abellotti merged commit c22dca5 into ManageIQ:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@abellotti abellotti abellotti approved these changes

Assignees

@abellotti abellotti

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharlleDaniel @Fryguy @miq-bot @abellotti @bdunne