Preserve contract for expressions of alert definitions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires setting the `@additional_attributes` to include `"expression"` for GET and POST (update) requests. For POST (create) requests, because the object is wrapped in a "results" object, we need to do a bit of a hack to insert the expression into a serialized version of the alert definition before it gets rendered.
|
Checked commit imtayadeway@326e2e5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
abellotti
reviewed
Sep 7, 2017
| private | ||
|
|
||
| def set_additional_attributes | ||
| @additional_attributes = %w(expression notify_email) |
There was a problem hiding this comment.
Even though I'm curious about this as well, this gets us to green so I'm merging... Let's follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires setting the
@additional_attributesto include"expression"for GET and POST (update) requests. For POST (create)requests, because the object is wrapped in a "results" object, we need
to do a bit of a hack to insert the expression into a serialized
version of the alert definition before it gets rendered.
@miq-bot add-label bug
@miq-bot assign @abellotti