Add guest_devices support to the API #7
Conversation
|
@miq-bot add_label wip |
miq-bot
changed the title
|
@miq-bot remove_label wip |
miq-bot
changed the title
|
@abellotti Can we get this PR merged now that ManageIQ/manageiq#15371 has been merged? Thanks |
|
This LGTM!!. @imtayadeway quick 👀 when you get a chance ? Thanks. |
| end | ||
| end | ||
|
|
||
| context "with an invalid role" do |
There was a problem hiding this comment.
Nit, but wording here is misleading. It's not that the role is invalid, it's that the user's role does not authorize them to use this feature. Similarly, it doesn't fail - it does the right thing! i.e. respond with a forbidden status. Let's merge this as-is though, maybe you could consider rewording this in a follow up?
|
Checked commits skovic/manageiq-api@540d142~...25b7d1d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@imtayadeway I reworded the descriptions in the test file. Let me know if it looks OK now. Also, I noticed that guest_devices_spec.rb was in spec/requests/api/ instead of spec/requests/ so I moved it to spec/requests/ -- this must have happened while migrating these changes to this repo. |
|
@skovic thanks for making those changes! 😻 This looks great - it's just failing because of some upstream breakages - I'll restart your build once those are under control. |
|
@imtayadeway yeah still looks like it's failing, what's the upstream issue causing it? |
|
Thanks @skovic for the API Enhancement !! 👍 |
This PR adds guest_devices support to the API.